lightningd: deprecate decodepay. #7551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
There are some CI failure here and there
===End Flaky Test Report===
=========================== short test summary info ============================
FAILED tests/test_cln_rs.py::test_grpc_decode - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
status = StatusCode.UNKNOWN
details = "Error calling method DecodePay: RpcError { code: Some(-32601), message: "Command \"decodepay\" is deprecated", data: None }"
debug_error_string = "UNKNOWN:Error received from peer {grpc_message:"Error calling method DecodePay: RpcError { code: Some(-32601), message: \"Command \\\"decodepay\\\" is deprecated\", data: None }", grpc_status:2, created_time:"2024-08-11T04:19:59.35794186+00:00"}"
>
=========== 1 failed, 613 passed, 156 skipped in 1521.13s (0:25:21) ============
rustyrussell
force-pushed
the
guilt/deprecate-decodepay
branch
from
b73b30b to
267a753
Compare
|
Trivial rebase, and changed deprecation from 24.08 to 24.11. |
It only works on BOLT11, and has long been replaced by the more generic "decode". Removing it will stop the confusion! (Note: documentation claims it was introduced in 23.08, but that was wrong, as it's been in CLN since the beginning). [ Fixup from: niftynei <[email protected]> ] Fixes: ElementsProject#6419 Changelog-Deprecated: JSON-RPC: `decodepay`: use `decode`. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/deprecate-decodepay
branch
from
267a753 to
3ddde12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only works on BOLT11, and has long been replaced by the more generic "decode".
Removing it will stop the confusion!
(Note: documentation claims it was introduced in 23.08, but that was
wrong, as it's been in CLN since the beginning).
Fixes: #6419
Changelog-Deprecated: JSON-RPC:
decodepay: usedecode.